Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More friendly experience when presenting repack options #270

Merged
merged 46 commits into from
May 18, 2024
Merged

More friendly experience when presenting repack options #270

merged 46 commits into from
May 18, 2024

Conversation

ChristoferMendes
Copy link
Contributor

@ChristoferMendes ChristoferMendes commented May 10, 2024 •
edited

CHANGES MADE

  • Add a new file for getting info from title (multiplayer/multixx)
  • Add new components (Tag, Tooltip)
  • Add fetch of peers/seeders (with 2 minutes of cache)
  • Add language of installer ('ru' for Xatab, 'en' for others)
UI

repacks-modal

#225

@ChristoferMendes
feat: Add repack language codes to translation files
02c4f0a
@ChristoferMendes
feat(events): Add new event for getting magnet data
a0344ea
@ChristoferMendes
feat: Add new Tag component with styling for tags
08c4906
@ChristoferMendes
feat: Add tooltip component with styles and visibility logic
1872ff1
@ChristoferMendes
feat: Add SeedersAndPeers component with skeleton loader
58693fd
@ChristoferMendes
style: Add styling for tags container in repacks modal
2662ba3
@ChristoferMendes
feat: Add functions for multiplayer repack, multi-language support, a…
ada218c 
…nd repack language based on repacker
@ChristoferMendes
feat: Add new functionality to display repack language and seeders/pe…
06ed5e0 
…ers in RepacksModal
@ChristoferMendes
feat: Add lucide-react package to dependencies
09bd7dc
@ChristoferMendes
feat: Add openWebTorrent service for fetching seeders and peers
b84df28
@ChristoferMendes
refactor: Update function calls from savePage to saveRepacks in multi…
92f35ba 
…ple files
@ChristoferMendes
feat: Add getMagnetData function to global declaration
ff6a204
@ChristoferMendes ChristoferMendes changed the title Feature/better repack modal More friendly experience when presenting repack options May 10, 2024
@JackEnx JackEnx self-assigned this May 10, 2024
@JackEnx
Copy link
Collaborator

JackEnx commented May 11, 2024

run "yarn lint", there some errors to fix.

image

@ChristoferMendes
Copy link
Contributor Author

ChristoferMendes commented May 12, 2024 •
edited

@JackEnx, could you revisit this? Updated the code with the requested changes

hydralauncher
hydralauncher suggested changes May 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/locales/en/translation.json Outdated Show resolved Hide resolved
src/main/events/index.ts Outdated Show resolved Hide resolved
src/main/services/open-web-torrent.ts Outdated Show resolved Hide resolved
src/main/services/repack-tracker/1337x.ts Outdated Show resolved Hide resolved
src/preload/index.ts Outdated Show resolved Hide resolved
src/renderer/src/components/tag/tag.css.ts Show resolved Hide resolved
src/renderer/src/components/tag/tag.css.ts Outdated Show resolved Hide resolved
src/renderer/src/components/tag/tag.css.ts Outdated Show resolved Hide resolved
src/renderer/src/pages/game-details/seeders-and-peers/useMagnetData.tsx Outdated Show resolved Hide resolved
@ChristoferMendes
Copy link
Contributor Author

Repacks from onlinefix should have the multiplayer tag. Could you check this feature? It does not seem to be working here

image

Will check

@ChristoferMendes
Copy link
Contributor Author

Repacks from onlinefix should have the multiplayer tag. Could you check this feature? It does not seem to be working here

image

Fixed! I was not checking for the repacker itself, only title

@zamitto zamitto self-requested a review May 15, 2024 20:48
@zamitto
Copy link
Collaborator

zamitto commented May 15, 2024

You last thing I think.
Are all magnets returning 0 seeders and 0 peers for you as well?
image

@ChristoferMendes
Copy link
Contributor Author

You last thing I think.
Are all magnets returning 0 seeders and 0 peers for you as well?
image

Strange, for me it was okay. I'll check it out

@zamitto
Copy link
Collaborator

zamitto commented May 15, 2024

You last thing I think.
Are all magnets returning 0 seeders and 0 peers for you as well?
image

Strange, for me it was okay. I'll check it out

Yeah, the log says timeout for all trackers. It's strange.

@JackEnx
Copy link
Collaborator

JackEnx commented May 15, 2024 •
edited

earlier I was checking this timeout issue, one way I did it was to check when empty, then i triggering a second request with a longer time, below is an example, its just a example

image

first request, 1 second

image

second request, 10 seconds after the first request

image

@ChristoferMendes
Copy link
Contributor Author

ChristoferMendes commented May 15, 2024 •
edited

@JackEnx

Applied retry logic here: 7a2b693.

It's all zeros for me too (it wasn't like this before :/). Adding a 1.5-second delay prevents the error for some cases. In case it does not return, the function will retry

zamitto
zamitto requested changes May 16, 2024
View reviewed changes
src/main/services/web-torrent-data.ts Outdated Show resolved Hide resolved
@zamitto
Copy link
Collaborator

zamitto commented May 17, 2024

will try to finish reviewing your pr todat, we are kinda busy this week

@ChristoferMendes
Copy link
Contributor Author

will try to finish reviewing your pr todat, we are kinda busy this week

Thank you!

@zamitto zamitto merged commit e5fec91 into hydralauncher:main May 18, 2024
1 check passed
@zamitto zamitto mentioned this pull request May 18, 2024
Merged
@zamitto
Copy link
Collaborator

zamitto commented May 18, 2024

@ChristoferMendes, I had merged your PR earlier, but we will actually test it a little more before an actual merge

@zamitto
Copy link
Collaborator

zamitto commented May 18, 2024

If you could recreate the PR that would be nice

@ChristoferMendes
Copy link
Contributor Author

If you could recreate the PR that would be nice

Recreate it? Without changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamitto zamitto zamitto approved these changes

@JackEnx JackEnx Awaiting requested review from JackEnx

@hydralauncher hydralauncher Awaiting requested review from hydralauncher

Assignees

@JackEnx JackEnx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChristoferMendes @JackEnx @zamitto @hydralauncher