Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose formatted service name as a const fn #1684

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkatychev
Copy link

Motivation

It is oftentimes cumbersome to use tonic::server::NamedService::NAME when T has multiple generics:

impl<T: ServerTrait> tonic::server::NamedService for ServiceServer<T> {
    const NAME: &'static str = "service_api.Service";
}

This is particularly egregious when using the HealthReporter methods since HealthReporter::set_serving requires a fully qualified ServiceServer<T>:

let (mut health_reporter, health_service) = tonic_health::server::health_reporter();
health_reporter.set_serving::<MyServer<MyInner<MyLongQualifiedType, MyOtherQualifiedType, T, T2>>>().await;

Solution

expose a pub const fn service_name() -> &'static str that returns the formatted string.

@AmeliasCode
Copy link

+1 to this! It would make it a lot less verbose to get the service name.


quote! {
#name_doc
pub const fn service_name() -> &'static str {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would still make sense for this to a const SERVICE_NAME: &str?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants