Support public key recovery for EIP-155 transactions #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishin195
approved these changes
Jan 12, 2024
NickSneo
reviewed
Mar 13, 2024
| MAIN_NET(1); | ||
| MAIN_NET(1), | ||
| GOERLI(5), | ||
| SEPOLIA(58008); |
There was a problem hiding this comment.
Sepolia ChainId is 11155111?
| MAIN_NET(1), | ||
| GOERLI(5), | ||
| SEPOLIA(58008); | ||
|
|
There was a problem hiding this comment.
Plz add Holesky chainId too 17000
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1977 +/- ##
============================================
+ Coverage 68.45% 69.20% +0.75%
- Complexity 3005 3117 +112
============================================
Files 488 493 +5
Lines 12568 13091 +523
Branches 1643 1691 +48
============================================
+ Hits 8603 9060 +457
- Misses 3485 3540 +55
- Partials 480 491 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It supports recovery of public keys when the transaction use the anti replay protection (EIP 155)
Where should the reviewer start?
PR is quite short
Why is it needed?
Most of txs are protected with EIP 155