Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add 3Column-Tall layout variants #1128

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

rraihansaputra
Copy link

@rraihansaputra rraihansaputra commented Jun 29, 2021

Add 3Column-Tall layout variants, based off the 3Column layout but the main pane is split vertically (like Tall splits the screen).

3column-tall.mp4

Requesting comments on:

  • Currently I'm implementing it by adding a Stack variant into the 3Column layout. Please let me know if this adds too much complexity.
  • The name. Is 3Column Tall descriptive enough?

Draft tasks:

  • Modify ThreeColumnLayout to accept and work with mainColumnStack specification
  • register the layout on LayoutType.swift
  • Add tests regarding the Tall variants
    • add tests verifying split on the main column
    • add more thorough tests using the frame verifier
  • Add layout info to README.md

Amethyst/Layout/Layouts/ThreeColumnLayout.swift Outdated Show resolved Hide resolved
Amethyst/Layout/Layouts/ThreeColumnLayout.swift Outdated Show resolved Hide resolved
Amethyst/Layout/Layouts/ThreeColumnLayout.swift Outdated Show resolved Hide resolved
Amethyst/Layout/Layouts/ThreeColumnLayout.swift Outdated Show resolved Hide resolved
@rraihansaputra rraihansaputra marked this pull request as draft June 29, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants