-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Software' after 'Open Fair-Code Source' for clarity in translations #1064
Open
Loujayna1
wants to merge
25
commits into
idurar:dev
Choose a base branch
from
Loujayna1:update-readme
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some code changes
code commit
Update to 4.0.0-beta.3
removed wrong code
Updated invoice title
Updated space
Updated content
Added discount option in code
Fix Adding new admin bug
added address in customer
Branch discount
Revert "Branch discount"
Fixed typo in readme.md
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
This reverts commit 681f175.
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
Fix: Update Dockerfile to use correct npm script for frontend service
fix 'req is undefined' error in payment controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue where the phrase "open fair-code source" lacks clarity for translation into languages like French and German due to the absence of a noun. By adding the word "software" after "open fair-code source," the phrase becomes "open fair-code source software," providing context and improving the accuracy of translations.
Related Issues
#996
Checklist