Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: upload progress bar #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature: upload progress bar #43

wants to merge 3 commits into from

Conversation

ywx217
Copy link

@ywx217 ywx217 commented Feb 15, 2020

Enable progress bar for file & HTTP uploading

@codecov-io
Copy link

Codecov Report

Merging #43 into master will decrease coverage by 0.08%.
The diff coverage is 40.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   31.21%   31.12%   -0.09%     
==========================================
  Files           8        8              
  Lines         346      363      +17     
==========================================
+ Hits          108      113       +5     
- Misses        232      243      +11     
- Partials        6        7       +1
Impacted Files Coverage Δ
cli/http.go 3.57% <ø> (ø) ⬆️
cli/cli.go 0% <ø> (ø) ⬆️
photos/add.go 67.01% <0%> (-1.42%) ⬇️
photos/types.go 0% <0%> (ø) ⬆️
cli/upload.go 38.35% <33.33%> (-1.65%) ⬇️
photos/media_items.go 58.06% <63.63%> (-4.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be30e72...9f05da4. Read the comment docs.

@ywx217 ywx217 requested a review from int128 February 20, 2020 13:55
@int128 int128 added the enhancement New feature or request label Feb 20, 2020
@int128 int128 removed their request for review February 12, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants