Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @stencil/core to v4.18.0 #29487

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 10, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@stencil/core (source) 4.17.2 -> 4.18.0 age adoption passing confidence

Release Notes

ionic-team/stencil (@​stencil/core)

v4.18.0

Compare Source

Bug Fixes
Features

🏊 4.17.2 (2024-04-29)

Bug Fixes

🚒 4.17.1 (2024-04-23)

Bug Fixes

Configuration

📅 Schedule: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 10, 2024 00:28
@renovate renovate bot requested a review from thetaPC May 10, 2024 00:28
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 1:38pm

adds duplicate looking entries to the api.txt file, we'll update the
output target in the next commit
@rwaskiewicz
Copy link
Member

@thetaPC I updated this PR to account for the modes being reported in the output of api.txt. I split this into a few different commits:

  • 4159dd1 just reruns stencil build in core, where you can see all the duplicate-looking entries, now that we have a css property per mode
  • ad2271e updates the output target for api.txt to add the mode
  • a6e2428 updates the api.txt again, this time with the new OT

LMK if you have any questions!

CC: @brandyscarney @sean-perkins

Copy link
Contributor Author

renovate bot commented May 10, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@sean-perkins
Copy link
Contributor

Note

Once this is merged into main and syncing to next, the dev team will need to run npm run build from core/ to generate the updated contents of api.txt with the ionic mode. Otherwise CI will fail with the generated diff.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney
Copy link
Member

:shipit:

@thetaPC thetaPC added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit ea8a597 May 15, 2024
48 checks passed
@thetaPC thetaPC deleted the renovate/stencil branch May 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants