Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete outdated annotations #1187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omvjro
Copy link
Contributor

@omvjro omvjro commented Jan 21, 2024

目标章节:1-js/05-data-types/05-array-methods/8-sort-objects

当前上游最新 commit:无

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
solution.md 译注方法已写入正文,无需译注

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2024

CLA assistant check
All committers have signed the CLA.

@leviding
Copy link
Member

@omvjro 请问为什么认为被删掉的内容 outdated 了?

@leviding leviding added question Further information is requested and removed review needed labels Jan 21, 2024
@omvjro
Copy link
Contributor Author

omvjro commented Jan 22, 2024

@omvjro 请问为什么认为被删掉的内容 outdated 了?

译注:解决方案的代码还可以更短一些

实际上在 40fbdf3 这次提交后,译注里的代码和解决方案的代码没有区别。

而译注中之后补充的内容也在正文中提到了。

**这些元素默认情况下被按字符串进行排序。**

实际上,比较函数只需要返回一个正数表示“大于”,一个负数表示“小于”。

@leviding leviding added needs +1 and removed question Further information is requested labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants