Fix changing filters not resetting multiselected media cards #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorS1110
force-pushed
the
fix-multiselect-filter
branch
2 times, most recently
from
a5fa2cb
to
fdce2e2
Compare
|
This comment has been minimized.
This comment has been minimized.
|
@ConnorS1110 could you resolve the conflicts here? Now that 10.9 is finally out let's work on getting this in. 👍 |
ConnorS1110
force-pushed
the
fix-multiselect-filter
branch
from
fdce2e2
to
b2dbae0
Compare
|
|
@thornbill fixed the merge conflict and looks like everything is still good |
Cloudflare Pages deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Multi-selected options are now cleared by calling
hideSelectionsfrom themultiSelectcomponent when a change is triggered in thefilterdialogcomponent.hideSelectionsis also called in thelistcontroller when filters have been changed and there actually filters being applied instead of removed.Issues
Fixes #5209