Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lyrics Editor for Admin users only #5405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented Apr 22, 2024

Adds a lyrics editor dialog so that admin users can manually add, remove or search for lyrics through the web ui. Code is based on the subtitle editor.

Search has been tested using the LrcLib plugin

Changes

image
image
image
image

Issues

@scampower3 scampower3 requested a review from a team as a code owner April 22, 2024 12:25
@thornbill thornbill added this to the v10.10.0 milestone May 6, 2024
@thornbill thornbill added feature New feature or request release-highlight A major new feature for the next release labels May 6, 2024
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.5% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 2a9f7f6
Status ✅ Deployed!
Preview URL https://f524891a.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request release-highlight A major new feature for the next release
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants