Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to prioritise what audio codec to transcode to #5434

Merged
merged 12 commits into from
May 18, 2024

Conversation

scampower3
Copy link
Member

Add a setting to prioritise what audio codec to transcode to.

Changes

  • Adds a dropdown option to select what audio codec is preferred. (Options avaliable are abit arbitrary)
  • Shift the codec to the start of the string at getDeviceProfile function, will do nothing if the codec is not part of the transcodingProfile.AudioCodec string.

Issues

Helps resolve jellyfin/jellyfin-tizen#204

@scampower3 scampower3 requested a review from a team as a code owner April 30, 2024 11:10
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if audio codecs can simply be ordered by quality from best to worst?
The server will then select the first (best) one supported by the client and allowed by the server for transcoding.

src/scripts/settings/appSettings.js Outdated Show resolved Hide resolved
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "codec" to the name? 🤔

src/components/apphost.js Outdated Show resolved Hide resolved
src/components/apphost.js Outdated Show resolved Hide resolved
src/scripts/settings/appSettings.js Outdated Show resolved Hide resolved
@dmitrylyzo dmitrylyzo added the feature New feature or request label Apr 30, 2024
@@ -553,6 +553,7 @@
"LabelAudioCodec": "Audio codec",
"LabelAudioLanguagePreference": "Preferred audio language",
"LabelSelectAudioNormalization": "Audio Normalization",
"LabelSelectPreferredTranscodeAudioCodec": "Preferred transcode audio codec",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be explicit that this only affects Audio track in Videos. Because the Audio transcoding will use a very different server-side logic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we add a header?

    <div class="verticalSection verticalSection-extrabottompadding">
        <h2 class="sectionTitle">
            ${HeaderVideoAdvanced}
        </h2>

        <!-- select goes here -->

    <div>

Not sure about wording.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not rushing this with 10.9 release, then we can do a re-organize of the transcoding panel to make it easier to follow. It currently has a lot of options inside and a lot of options are actually very hard to find.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ideally there should be a dedicated view to customize the device profile.

The problem with the 10.9 release is that we can't add translations to the release branch - Weblate can only push to the master branch, iirc.

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

*AudioCodecInVideo could be renamed to *VideoAudioCodec (CodecProfiles for audio in video are marked with VideoAudio), but that's just nitpicking.

@dmitrylyzo dmitrylyzo added the playback This PR or issue mainly concerns playback label May 5, 2024
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 5, 2024
@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label May 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/scripts/settings/appSettings.js Outdated Show resolved Hide resolved
scampower3 and others added 2 commits May 5, 2024 16:20
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 012371e
Status ✅ Deployed!
Preview URL https://ebbdb663.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill added this to the v10.10.0 milestone May 6, 2024
@thornbill thornbill merged commit 32fc338 into jellyfin:master May 18, 2024
12 checks passed
@scampower3 scampower3 deleted the add-prefer-transcode-audio branch May 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request playback This PR or issue mainly concerns playback
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Transcode Audio to AC3 instead of AAC
5 participants