Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finer playback speed between 0.75x and 1.25x (in 0.05 increments) #5495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maatss
Copy link

@Maatss Maatss commented May 13, 2024

Changes
Adds additional 8 playback speeds for finer playback control. Speeds are between 0.75x and 1.25x in 0.05 increments.

Feature request
https://features.jellyfin.org/posts/2662/finer-playback-speeds-0-95x-1x-1-05x-1-1x

Add myself as contributor as per the contributor docs
@Maatss Maatss requested a review from a team as a code owner May 13, 2024 17:02
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Maatss
Copy link
Author

Maatss commented May 13, 2024

Given the increased number of playback speed options, it would look nicer if the selection dialog was given a max-height attribute, and thus introducing a scroll bar. However, I could not find an easy way to do this..

@ferferga
Copy link
Member

I'd say that doing it as a combobox (like in jellyfin-vue) would provide a far better UX.

@Maatss
Copy link
Author

Maatss commented May 13, 2024

@ferferga I have not seen that client so not entirely sure what you mean. This is the difference of just introducing a max-height: 30% attribute to the dialog for reference.

Current:
Current_layout

w/ max-height: 30%
suggested_layout

@thornbill thornbill added the ui & ux This PR or issue mainly concerns UI & UX label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants