Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chromecast support #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jwbuiter
Copy link
Contributor

@jwbuiter jwbuiter commented Feb 1, 2021

Description

Adds a new modal which can be used to cast files with supported file formats to a chromecast.
The modal can be opened from a context menu item on a selected torrent.
Users can select the file to be casted and subtitles.
After starting the cast, the cast can be paused/played and the progress can be viewed.

Chromecasting is only supported on some browsers and only from secure domains.

Supported subtitle formats:

  • .vtt
  • .srt
  • subtitles embedded in .mkv video files

Screenshots

image

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #186 (4e6c952) into master (227c48a) will increase coverage by 0.40%.
The diff coverage is 22.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   78.62%   79.02%   +0.40%     
==========================================
  Files          57       56       -1     
  Lines        9211     9068     -143     
  Branches      910      925      +15     
==========================================
- Hits         7242     7166      -76     
+ Misses       1958     1890      -68     
- Partials       11       12       +1     
Impacted Files Coverage Δ
server/routes/api/torrents.ts 53.58% <18.30%> (-10.60%) ⬇️
server/routes/api/index.ts 74.07% <37.77%> (+12.30%) ⬆️
server/util/fileUtil.ts 50.54% <0.00%> (-31.27%) ⬇️
server/routes/api/feed-monitor.ts 92.92% <0.00%> (-4.05%) ⬇️
...er/services/rTorrent/util/torrentPropertiesUtil.ts 79.56% <0.00%> (-2.16%) ⬇️
server/util/torrentPropertiesUtil.ts 92.30% <0.00%> (-2.14%) ⬇️
...erver/services/qBittorrent/clientRequestManager.ts 64.42% <0.00%> (-1.52%) ⬇️
server/routes/api/client.ts 95.12% <0.00%> (-1.13%) ⬇️
...erver/services/qBittorrent/clientGatewayService.ts 73.86% <0.00%> (-0.89%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227c48a...4d686bf. Read the comment docs.

@jesec jesec self-assigned this Feb 2, 2021
@jesec
Copy link
Owner

jesec commented Feb 2, 2021

CI has to pass. Additionally, use Node 15 and npm 7 to develop, so you can get a proper package-lock.json.

@jesec
Copy link
Owner

jesec commented Feb 16, 2021

Please pull https://github.com/jesec/flood/tree/pr/186. I cleaned the changes up a bit.

@luzpaz
Copy link

luzpaz commented Jul 25, 2023

Is there an ETA on this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants