-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't make elements after enum part of enum 'module' #1686
base: main
Are you sure you want to change the base?
Conversation
409c000
to
b8e0e80
Compare
Hello, are there any reasons that blocks merge of this PR? |
Merge this 🙏 |
Can we please have this merged? It is 100% relevant and breaking protobuf.js pbts TypeScript from jsdoc conversion. |
Can this be merged yet? Its passed all checks for a month now. |
Bumping this issue |
+1 |
+1, breaking our typescript protobuf.js models as well |
Same issue here <3 |
+1 |
bump! pls merge :) |
I was looking at this commit. Shouldn't there be a 'module' and a 'member'? The enum shouldn't become a 'module'. |
Bump! Please merge 🙏 |
I updated according to latest version: #2046 could this be finally merged? |
While generating a TypeScript declaration file for some protobuf messages, I came across a strange issue where no types after an enum was exported were included in the declaration file. I tracked the issue down to an issue in jsdoc where any export in a file after an enum is exported is considered to be a child of the enum. It looks like this behavior was added during a fix for #970.
The simple workaround for my case was to define the enum in a separate file, but I'd rather just fix the problem to avoid running into the same problem six months from now, forgetting the solution, and going through the process all over again!