docs: add section about isolated declarations #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/docs/about-slow-types.md
Outdated
| However, there are some differences between the two: | ||
|
|
||
| - Isolated declarations require that all symbols that are exported from a module | ||
| follow the "no inference" rules. JSR only requires that symbos that are |
There was a problem hiding this comment.
Suggested change
| follow the "no inference" rules. JSR only requires that symbos that are | |
| follow the "no inference" rules. JSR only requires that symbols that are |
| - Isolated declarations require that all symbols that are exported from a module | ||
| follow the "no inference" rules. JSR only requires that symbos that are | ||
| actually part of the public API of a package follow the "no inference" rules. | ||
| - Isolated declarations is sometimes more strict than JSR. For example, isolated |
There was a problem hiding this comment.
Nit: Should we show an example of what that looks like? Not sure if JS devs are familiar with the term function expression body.
marvinhagemeister
approved these changes
May 15, 2024
lucacasonato
force-pushed
the
comparing_to_id
branch
from
08ca703
to
faf410c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495