Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new settings nodeIntegration #312 #314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

niconil
Copy link

@niconil niconil commented Nov 18, 2023

Add this settings to allow correct loading of authentication page when uses JQuery. By default nodeIntegration keeps its true value to not introduce any change. More description in #312 .

@8bitZeta
Copy link

This will still fail for me unless contextIsolation: true is removed.

Can you check to see if the changes work for you with that parameter either being set to true or removing it, @niconil?

@niconil
Copy link
Author

niconil commented Nov 29, 2023

ok i will modify my pullrequest to add this contextIsolation as a new variable in settings.json file
so anyone can adjust its configuration to suit their connection context

@niconil
Copy link
Author

niconil commented Dec 3, 2023

ok the pull request is modified
you can adjust in settings the value of
contextIsolation and/or nodeIntegration

@zeitounator
Copy link

Shouldn't contextIntegration be true by default? Having it false currently seems to break many corporate saml login integrations (see #312 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants