Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cortexOrgID from Prometheus scaler #5539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MeenuyD
Copy link

@MeenuyD MeenuyD commented Feb 27, 2024

In line with the deprecation of cortexOrgID in v2.10 and its scheduled removal in v2.12, this commit removes all references to cortexOrgID within the Prometheus scaler codebase and documentation.
Fixes #5538

@MeenuyD MeenuyD requested a review from a team as a code owner February 27, 2024 17:30
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
@tomkerkhove
Copy link
Member

Mind updating the docs as well please?

@MeenuyD
Copy link
Author

MeenuyD commented Feb 27, 2024

Done

@SpiritZhou
Copy link
Contributor

Could you help to update the CHANGELOG?

@MeenuyD
Copy link
Author

MeenuyD commented Mar 4, 2024

Can you please tell me where should i update i am new in this

@SpiritZhou
Copy link
Contributor

You can update it in https://github.com/kedacore/keda/blob/main/CHANGELOG.md

There is a checklist in default description when you create a PR. You can follow it in the next time.

Checklist

@JorTurFer
Copy link
Member

JorTurFer commented Mar 10, 2024

Can you please tell me where should i update i am new in this

this is the file https://github.com/kedacore/keda/blob/main/CHANGELOG.md 😄

@tomkerkhove
Copy link
Member

@MeenuyD Any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of cortexOrgID within prometheus scaler
4 participants