Validate regex before building image for e2e test #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
|
@JorTurFer PTAL. |
zroubalik
reviewed
May 17, 2024
CHANGELOG.md
Outdated
| @@ -64,6 +64,7 @@ Here is an overview of all new **experimental** features: | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| - **General**: Added Pre Regex check before building image in e2e test ([#5783](https://github.com/kedacore/keda/issues/5783)) | |||
There was a problem hiding this comment.
please move this into Other section
|
/run-e2e nonsense |
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
JorTurFer
reviewed
May 18, 2024
This won't help here, because the workflow is executed from |
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
JorTurFer
reviewed
May 18, 2024
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
JorTurFer
approved these changes
May 26, 2024
|
/skip-e2e |
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Regex check before building image and made refactored changes accordingly.
Checklist
Fixes #4750
Relates to #