Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display success message after transaction is in block #10293

Merged
merged 23 commits into from
May 21, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented May 14, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

changed normal and auto-teleport flow of:

  • create collection
  • buy nft
  • list nft

@prury pls test all these flows

note: mint drop will be a follow up, blocked by

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

buy

normal

CleanShot.2024-05-16.at.12.28.46.mp4

autotelport

CleanShot.2024-05-16.at.12.22.09.mp4

create collection with autotelport

CleanShot.2024-05-16.at.09.40.51.mp4

listing cart autoteleport

CleanShot.2024-05-16.at.10.59.03.mp4

Copy link

netlify bot commented May 14, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e74a049
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6645d4c547256b0008759794
😎 Deploy Preview https://deploy-preview-10293--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit e74a049 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

View more on Code Climate.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian marked this pull request as ready for review May 16, 2024 09:56
@hassnian hassnian requested a review from a team as a code owner May 16, 2024 09:56
@hassnian hassnian requested review from vikiival and removed request for a team May 16, 2024 09:56
@hassnian hassnian requested a review from daiagi May 16, 2024 09:56
@prury
Copy link
Member

prury commented May 16, 2024

superb testing @hassnian!

@prury prury requested a review from preschian May 16, 2024 20:11
@prury
Copy link
Member

prury commented May 16, 2024

only i could not test was collection creation, as success modal does not open here for me(issue opened), but the other interactions work fine. And i guess for NFT creation we still don't show success modal?

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 16, 2024
@hassnian
Copy link
Contributor Author

hassnian commented May 17, 2024

And i guess for NFT creation we still don't show success modal?

nope we don't have that one implemented, I guess it would be the same as the successful drop modal . cc @exezbcz

@vikiival
Copy link
Member

cc @preschian can you please review?

@prury prury added this pull request to the merge queue May 21, 2024
Merged via the queue into kodadot:main with commit bd8cc9f May 21, 2024
18 of 19 checks passed
@prury prury deleted the issue-10231 branch May 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display success message after transaction is in block
5 participants