-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display success message after transaction is in block #10293
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…into issue-10231
…into issue-10231
…d use of debounce
Code Climate has analyzed commit e74a049 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Quality Gate passedIssues Measures |
superb testing @hassnian! |
only i could not test was collection creation, as success modal does not open here for me(issue opened), but the other interactions work fine. And i guess for NFT creation we still don't show success modal? |
nope we don't have that one implemented, I guess it would be the same as the successful drop modal . cc @exezbcz |
cc @preschian can you please review? |
PR Type
Context
changed normal and auto-teleport flow of:
@prury pls test all these flows
note: mint drop will be a follow up, blocked by
Needs QA check
Needs Design check
Did your issue had any of the "$" label on it?
Screenshot 📸
buy
normal
CleanShot.2024-05-16.at.12.28.46.mp4
autotelport
CleanShot.2024-05-16.at.12.22.09.mp4
create collection with autotelport
CleanShot.2024-05-16.at.09.40.51.mp4
listing cart autoteleport
CleanShot.2024-05-16.at.10.59.03.mp4