-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac(halo2): change concrete struct type to trait type for rng #394
base: main
Are you sure you want to change the base?
refac(halo2): change concrete struct type to trait type for rng #394
Conversation
Thanks for your contribution! 🎉 Firstly, could you please follow the commit convention outlined here? Additionally, it's essential that every commit is buildable and testable, but unfortunately, your PR doesn't meet these criteria. To address this, I suggest squashing all the commits into a single one to ensure they're buildable and testable. Let me know if you have any questions or need further clarification. Thanks again for your effort! 👍 |
1ded7a6
to
fc029f6
Compare
…iftRng with generic R which implements RngState
fc029f6
to
28a22d5
Compare
@k-gunjan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change your commit's scope to match the PR's scope (Halo2)? Thanks again for the contribution~ 🥰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR makes rng parameter of create_proof function generic over RngCore and RngState.
Defined trait RngState and implemented for XORShiftRng