-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fail admission check upon empty overhead map #124899
base: master
Are you sure you want to change the base?
Fix: Fail admission check upon empty overhead map #124899
Conversation
Welcome @nmreadelf! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @nmreadelf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nmreadelf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/sig node |
What type of PR is this?
/kind bug
What this PR does / why we need it:
the runtime class admission has a validation check against pod's
.spec.overhead
field. This validation is not correctly implemented because it's still failing requests if the request payload just has an empty map e.g.:Which issue(s) this PR fixes:
Fixes #kubernetes-client/java#3076
Special notes for your reviewer:
Does this PR introduce a user-facing change?