-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to structured logging in cluster-bootstrap #124905
base: master
Are you sure you want to change the base?
Migrate to structured logging in cluster-bootstrap #124905
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @hiroki-it. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hiroki-it The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems cleaner after the diff, but this part of the code is included in community owned tools like kubeadm or external tools that don't benefit from struct logging.
does the KEP actually target cluster-bootstrap or is this your proposal for a change target @hiroki-it ?
/sig insrumentation
@neolit123: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig instrumentation |
/assign @shiva1333 |
@dgrisonnet: GitHub didn't allow me to assign the following users: shiva1333. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks for checking PR! Sorry, I mistakenly thought cluster-bootstrap was a package related to Kubernetes itself, and I didn't realize cluster-bootstrap was a package used by those tools not Kubernetes. I will check the KEP documentation to see if it is a target 👍 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
I've worked on migrating to structured logging in cluster-bootstrap :)
In changing loggers and log messages, I read the following documents.
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: