Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #124906: Fix printPod panic with spurious container statuses #124908

Merged
merged 1 commit into from
May 17, 2024
Merged

Automated cherry pick of #124906: Fix printPod panic with spurious container statuses #124908

merged 1 commit into from
May 17, 2024

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 16, 2024 •
edited

Cherry pick of #124906 on release-1.30.

#124906: Fix printPod panic with spurious container statuses

For details on the cherry pick process, see the cherry pick requests page.

kube-apiserver: fixes a 1.28 regression printing pods with invalid initContainer status

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 16, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@SergeyKanzhelev
Copy link
Member

/release-notes kube-apiserver: fixes a 1.28 regression printing pods with invalid initContainer status
/kind bug
/sig node
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2024
@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99e4bea50b4e5dfc028f70f21c5175d7216c5d7a

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 16, 2024
@SergeyKanzhelev
Copy link
Member

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team May 16, 2024 16:04
@liggitt
Copy link
Member Author

liggitt commented May 16, 2024

/remove-priority critical-urgent
/priority important-soon

it only panics the individual request, and only when there's a system client writing bad pod status... this seems fairly well scoped

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels May 16, 2024
@liggitt
Copy link
Member Author

liggitt commented May 16, 2024

@kubernetes/release-managers

cpanato
cpanato approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 17, 2024
@cpanato
Copy link
Member

cpanato commented May 17, 2024

/hold to wait #124910 to have a lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 17, 2024
@SergeyKanzhelev
Copy link
Member

/hold to wait #124910 to have a lgtm

Sorry, missed that one: #124910 (review)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 279863d into kubernetes:release-1.30 May 17, 2024
16 checks passed
SIG Node PR Triage automation moved this from Triage to Done May 17, 2024
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.30.1
6aa8d01 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.30.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.30.1-1.spec
    cp ../kubernetes*1.30.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.30.1/
    rm -rf ../kubernetes*1.30.1*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.28.10
3f24dfb 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.28.10.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.28.10-1.spec
    cp ../kubernetes*1.28.10*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.28.10/
    rm -rf ../kubernetes*1.28.10*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.29.5
875bedb 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.29.5.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.29.5-1.spec
    cp ../kubernetes*1.29.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.29.5/
    rm -rf ../kubernetes*1.29.5*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.28.10
25c55ff 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.28.10.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.28.10-1.spec
    cp ../kubernetes*1.28.10*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.28.10/
    rm -rf ../kubernetes*1.28.10*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.29.5
9fd3cf8 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.29.5.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.29.5-1.spec
    cp ../kubernetes*1.29.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.29.5/
    rm -rf ../kubernetes*1.29.5*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 3, 2024
@hswong3i
alvistack/v1.30.1
b170770 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.30.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.30.1-1.spec
    cp ../kubernetes*1.30.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.30.1/
    rm -rf ../kubernetes*1.30.1*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 5, 2024
@hswong3i
alvistack/v1.28.10
cdf03e3 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.28.10.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.28.10-1.spec
    cp ../kubernetes*1.28.10*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.28.10/
    rm -rf ../kubernetes*1.28.10*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 5, 2024
@hswong3i
alvistack/v1.29.5
748dca0 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.29.5.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.29.5-1.spec
    cp ../kubernetes*1.29.5*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.29.5/
    rm -rf ../kubernetes*1.29.5*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/kubernetes-kubernetes that referenced this pull request Jun 5, 2024
@hswong3i
alvistack/v1.30.1
aabdc15 
    git clean -xdf
    go mod download
    go mod vendor
    git checkout HEAD -- vendor
    tar zcvf ../kubernetes_1.30.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp kubernetes.spec ../kubernetes_1.30.1-1.spec
    cp ../kubernetes*1.30.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/kubernetes-kubernetes-1.30.1/
    rm -rf ../kubernetes*1.30.1*.*

See kubernetes#124933
See kubernetes#124908

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

@seans3 seans3 Awaiting requested review from seans3

Assignees

@cpanato cpanato

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @SergeyKanzhelev @cpanato