test: improve unit tests for container name autocompletion

[TessaIO]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleanup and add some tests for unit tests for container name autocompletion.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1600

Special notes for your reviewer:

Does this PR introduce a user-facing change?

N/A

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[TessaIO]

ping @ardaguclu @ah8ad3 since you already have context on this.

[TessaIO]

/retest

[ah8ad3]

Thanks for PR!
I haven't check to see if is there any other function that can be replaced with this test table too.

[TessaIO]

@ah8ad3 should I update all of them?

[ah8ad3]

should I update all of them?

My bad on not specifying my opinion, i think if there is for example 5 other tests that can be removed and put in the table here it would be better.
Updating all the tests could make reviews harder and maybe take long time to review.

[TessaIO]

should I update all of them?

My bad on not specifying my opinion, i think if there is for example 5 other tests that can be removed and put in the table here it would be better. Updating all the tests could make reviews harder and maybe take long time to review.

There are many of them in the completion_test.go. I suggest doing that in a separate PR to make the review easier. wdyt?

[TessaIO]

/retest

[ah8ad3]

LGTM thanks!

[seans3]

/triage accepted

[TessaIO]

ping @brianpursley @ardaguclu

[TessaIO]

@brianpursley thanks for the review! Updated and PTAL.

[TessaIO]

/retest

[brianpursley]

I see the unit tests failed after moving the lines as I had suggested. I'm not sure why those lines need to be inside the loop, but there must be something that needs to be reset for each test (iostreams maybe?). I think you can put those lines back inside the loop like you had them and it should be fine.

[TessaIO]

I see the unit tests failed after moving the lines as I had suggested. I'm not sure why those lines need to be inside the loop, but there must be something that needs to be reset for each test (iostreams maybe?). I think you can put those lines back inside the loop like you had them and it should be fine.

@brianpursley Thanks and done. Also maybe it's one of the reasons that previous tests were separated.
Anyways PTAL when you have time.

[ah8ad3]

Thanks!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 17e70aa1ae4a12d1fa00daf09f960c731cad0d31

[ardaguclu]

That looks good to me and thank you. But next time it is better to work on the issues that are labelled with triage/accepted to prevent any waste of effort as request might be rejected by the maintainers.
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[k8s-ci-robot]

@TessaIO: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-unit	fe81d0d	link	true	/test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.