Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a comment that statuses lists are not being validated #124918

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added a comment that statuses lists are not being validated #124918

wants to merge 4 commits into from
+181 −60

Conversation

SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev commented May 16, 2024 •
edited

What type of PR is this?

/kind cleanup
/kind documentation
/sig node
/priority backlog

What this PR does / why we need it:

Adding a note to API will help troubleshoot issues in future. Ideally we need to add this validation to API, but it is not a priority and will require a big effort of ensuring backward compatibility. Thus I suggest we are limiting change with the documentation update.

Which issue(s) this PR fixes:

Related to: #124915

Special notes for your reviewer:

I also reviewed other instances where statuses collection is being iterated over. I didn't find anything dangerous there.

Please review commit-by-commit. It will be easier

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/code-generation area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels May 16, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 17, 2024
@SergeyKanzhelev
Copy link
Member Author

/retest

@SergeyKanzhelev
Copy link
Member Author

/cc @liggitt @mrunalp

liggitt
liggitt reviewed May 20, 2024
View reviewed changes
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request May 21, 2024
Open
@seans3
Copy link
Contributor

seans3 commented May 21, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 21, 2024
alculquicondor
alculquicondor reviewed May 29, 2024
View reviewed changes
pkg/apis/core/types.go
// init container will have ready = true, the most recently started container will have
// startTime set.
// The list must not contain entries with the same container name, and must only contain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not enforced, then the right word is should, instead of must.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
SIG Node PR Triage
Status: Needs Reviewer
SIG Node PR Triage
Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SergeyKanzhelev @k8s-ci-robot @k8s-triage-robot @seans3 @liggitt @alculquicondor