-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update an incorrect comment in kubeadm controlplane join phase #124920
Update an incorrect comment in kubeadm controlplane join phase #124920
Conversation
Welcome @kimsehwan96! |
Hi @kimsehwan96. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/triage accepted
/priority backlog
/ok-to-test
/kind cleanup
thanks
LGTM label has been added. Git tree hash: 9320dfb67220d578dfdd792afeb7c65f9fabfb63
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimsehwan96, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
Change an incorrect comment in
cmd/kubeadm/app/cmd/phase/join/controlplanejoin.go
kubernetes/cmd/kubeadm/app/cmd/phases/join/controlplanejoin.go
Lines 115 to 119 in 6d4250e
Above section is related with
external etcd topology
condition for HA control plane.What this PR does / why we need it:
Update an incorrect comment in kubeadm controlplane join phase.
Required for clearer behavior descriptions
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: