Fix: modify syncWorkflowStatus #6257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
suwliang3
requested review from
barnettZQG,
yangsoon and
FogDong
as code owners
suwliang3
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #6257 +/- ##
================================================
- Coverage 60.28% 36.05% -24.24%
================================================
Files 309 87 -222
Lines 47161 18584 -28577
================================================
- Hits 28430 6700 -21730
+ Misses 15743 10975 -4768
+ Partials 2988 909 -2079
Flags with carried forward coverage won't be shown. Click here to find out more.
β View full report in Codecov by Sentry. |
suwliang3
changed the title
|
Would you please give more details about how to reproduce the bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
π€ Generated by Copilot at 73112e1
Summary
ππ«π οΈ
Fix a bug that could create invalid workflow CRDs by skipping empty revisions. The change affects the
pkg/apiserver/domain/service/workflow.gofile.Walkthrough
Fixes #6244
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer