feat: support IVF_HNSW_SQ #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
|
leave docs and python to future PRs, or it's too large |
westonpace
approved these changes
May 15, 2024
rust/lancedb/src/index/vector.rs
Outdated
Comment on lines
312
to
324
| /// The number of neighbors to select for each vector in the HNSW graph. | ||
| /// The default value is 20. | ||
| pub fn m(mut self, m: usize) -> Self { | ||
| self.m = m; | ||
| self | ||
| } | ||
|
|
||
| /// The number of candidates to evaluate during the construction of the HNSW graph. | ||
| /// The default value is 300. | ||
| pub fn ef_construction(mut self, ef_construction: usize) -> Self { | ||
| self.ef_construction = ef_construction; | ||
| self | ||
| } |
There was a problem hiding this comment.
We can add this in a future PR (when we extend this to node and python perhaps) but we will want these parameters to include:
- What happens if this is set incorrectly?
- When should the user adjust the default?
rust/lancedb/src/index/vector.rs
Outdated
Comment on lines
227
to
228
| pub(crate) m: usize, | ||
| pub(crate) ef_construction: usize, |
There was a problem hiding this comment.
Can we use u64 instead of usize? We can convert to usize internally. I'd rather avoid usize in our public API since it is slightly more confusing to think about.
There was a problem hiding this comment.
sure, let me change it to u32 cause we don't need such great value of u64
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.