Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nodejs): use biomejs instead of eslint & prettier #1304

Merged
merged 6 commits into from
May 14, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented May 14, 2024

I've been noticing a lot of friction with the current toolchain for '/nodejs'. Particularly with the usage of eslint and prettier.

Biome is an all in one formatter & linter that replaces the need for two different ones that can potentially clash with one another.

I've been using it in the nodejs-polars repo for quite some time & have found it much more pleasant to work with.


One other small change included in this PR:

use ts-jest so we can run our tests without having to rebuild typescript code first

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to this.

We have pre-commit configuration for prettier right now. Could you switch that to biomejs?

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me. I have no particular attachment to prettier. I just picked it because whatever we had before didn't really enforce much. As long as biome is opinionated (don't make me think) and fast then I'm happy.

@universalmind303 universalmind303 merged commit 055efdc into lancedb:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants