Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website api doc rework #867

Open
wants to merge 267 commits into
base: main
Choose a base branch
from
Open

website api doc rework #867

wants to merge 267 commits into from

Conversation

QianZhu
Copy link
Contributor

@QianZhu QianZhu commented Jan 26, 2024

  1. combined oss and saas api docs
  2. marked parameters/apis if they are not supported on saas yet
Screenshot 2024-01-25 at 9 54 47 AM Screenshot 2024-01-25 at 9 54 55 AM

Lance Release and others added 30 commits October 16, 2023 15:12
Fix broken link to embedding functions

testing: broken link was verified after local docs build to have been
repaired

---------

Co-authored-by: Chang She <chang@lancedb.com>
Allows creation of funnels and user journeys
Sets things up for this -> #579
- Just separates out the registry/ingestion code from the function
implementation code
- adds a `get_registry` util
- package name "open-clip" -> "open-clip-torch"
To include latest v0.8.6

Co-authored-by: Chang She <chang@lancedb.com>
closes #564

---------

Co-authored-by: Chang She <chang@lancedb.com>
* Filename typo
* Remove rick_morty csv as users won't really be able to use it.. We can
create a an executable colab and download it from a bucket or smth.
…tions (#593)

Prior to this PR, to get a new version of a table, we need to re-open
the table. This has a few downsides w.r.t. performance:
* Object store is recreated, which takes time and throws away existing
warm connections
* Commit handler is thrown aways as well, which also may contain warm
connections
Closes #594

The embedding functions are pydantic models so multiple instances with
the same parameters are considered ==, which means that if you have
multiple embedding columns it's possible for the embeddings to get
overwritten. Instead we use `is` instead of == to avoid this problem.

testing: modified unit test to include this case
expose `optimize_index` api.
expose index remap options in `compact_files`
wjones127 and others added 24 commits January 19, 2024 13:09
@eddyxu added instructions for linting here:


https://github.com/lancedb/lancedb/blob/7af213801a091cd5afb0f0814e184fc0b852de47/python/README.md?plain=1#L45-L50

However, we had a lot of failures and weren't checking this in CI. This
PR fixes all lints and adds a check to CI to keep us in compliance with
the lints.
* improve the docstring for NodeJS connect functions and
`ConnectOptions` parameters.
* Simplify `npm run build` steps.
Add test to ingest fp16 to a database
Rust API doc for the braves
Support to make Apache Arrow Table from an array of javascript Records,
with optionally provided Schema.
Allow passing API key as env var:
```shell
export LANCEDB_API_KEY=sh_123...
```

with this set, apiKey argument can omitted from `connect`
```js
    const db = await vectordb.connect({
        uri: "db://test-proj-01-ae8343",
        region: "us-east-1",
  })
```
```py
    db = lancedb.connect(
        uri="db://test-proj-01-ae8343",
        region="us-east-1",
    )
```
#846)

In NodeJS and Python, LanceDB establishes a connection to a db. In Rust
core, it is called Database.
We should be consistent with the naming.
Use Napi to write a Node.js SDK that follows Polars for better
maintainability, while keeping most of the logic in Rust.
* Extract a minimal Table interface in Rust SDK
* Make create_index composable in Rust.
* Fix compiling issues from ffi
Created based on upstream PR lancedb/lance#1849

Closes #681

---------

Co-authored-by: Prashanth Rao <35005448+prrao87@users.noreply.github.com>
* Easy to type
* Handle `String, &str, [String] and [&str]` well without manual
conversion
* Fix function name to be verb
* Improve docstring of Rust.
* Promote `query` and `search()` to public `Table` trait
@QianZhu QianZhu requested a review from eddyxu January 26, 2024 00:18
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the repeated "this API is not yet available on LanceDB Cloud" looks bad.

//connect to a local database
const db = await lancedb.connect('data/sample-lancedb');
// connect to LanceDB Cloud
// const db = await lancedb.connect({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it looks weird having this in comments
  2. there's no context about LanceDB Cloud at all, or explaining what your-project-slug means, etc.

@@ -815,6 +817,7 @@ export class LocalTable<T = number[]> implements Table<T> {
/**
* Clean up old versions of the table, freeing disk space.
*
* Note: this API is not yet available on LanceDB Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think all of these repeated notes will make the docs look really messy. And chances are when we implement some of these in cloud we'll forget to update these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet