Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement storage for configs #170

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Implement storage for configs #170

wants to merge 5 commits into from

Conversation

nfcampos
Copy link
Collaborator

@nfcampos nfcampos commented Nov 4, 2023

  • tests
  • change return format to list of dicts, return inserted row from PUT endpoint

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2023
Base automatically changed from nc/ruff-format to main November 5, 2023 10:10
@nfcampos nfcampos marked this pull request as draft November 5, 2023 10:20
@eyurtsev
Copy link
Collaborator

eyurtsev commented Nov 8, 2023

  1. Should we provide a storage interface instead so folks can easily swap out sqlite for postgres or something else of their choosing?
  2. Should we have a single endpoint across all runnables? Is the main issue associated with identifying a runnable uniquely right now (i.e., are we relying on the path to identify which runnable we're working with?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants