Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for LZString methods with None input #642

Closed

Conversation

noobforvictory
Copy link

Hey there,

I'm thrilled to start contributing to the project! As a newcomer to open source, I'm focusing on writing unit tests to understand the code base. Any feedback or guidance is appreciated.

Copy link

cla-bot bot commented May 11, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @noobforvictory on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

@eyurtsev
Copy link
Collaborator

Hi @noobforvictory thanks for the contribution! It's better to focus on an existing issue rather than writing unit tests for existing.

I'd suggest starting with langchain-community (in the main langchain-repo) if you're getting started with python or looking for simple issues to contribute with.

@noobforvictory noobforvictory deleted the denis/test-cases branch May 16, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants