Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Retrieve Documents when using AiService #1015

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FEATURE] Retrieve Documents when using AiService #1015

wants to merge 3 commits into from

Conversation

KaisNeffati
Copy link
Contributor

Context

#660

Change

Checklist

Before submitting this PR, please check the following points:

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features)
  • I have added my new module in the BOM (only when a new module is added)

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

@KaisNeffati KaisNeffati changed the title [FEATURE] Retrieve Documents when using AiService or ConversationalRe… [FEATURE] Retrieve Documents when using AiService Apr 25, 2024
@langchain4j langchain4j added P1 Highest priority P2 High priority labels Apr 29, 2024
langchain4j
langchain4j requested changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaisNeffati thank you a lot for your contribution!

langchain4j/src/test/java/dev/langchain4j/service/AiServicesWithRagIT.java Outdated Show resolved Hide resolved
langchain4j/src/test/java/dev/langchain4j/service/AiServicesWithRagIT.java Outdated Show resolved Hide resolved
langchain4j/src/test/java/dev/langchain4j/service/AiServicesWithRagIT.java Outdated Show resolved Hide resolved
langchain4j/src/test/java/dev/langchain4j/service/AiServicesWithRagIT.java Outdated Show resolved Hide resolved
langchain4j/src/test/java/dev/langchain4j/service/AiServicesWithRagIT.java Outdated Show resolved Hide resolved
langchain4j/src/main/java/dev/langchain4j/service/WithSources.java Show resolved Hide resolved
langchain4j-core/src/main/java/dev/langchain4j/rag/RetrievalAugmentor.java Outdated Show resolved Hide resolved
langchain4j/src/main/java/dev/langchain4j/service/WithSources.java Outdated Show resolved Hide resolved
@KaisNeffati KaisNeffati force-pushed the feature/augmented_user_message branch from 951bc77 to 7cfac82 Compare May 6, 2024 12:07
@KaisNeffati KaisNeffati force-pushed the feature/augmented_user_message branch from 7cfac82 to 2d16e44 Compare May 6, 2024 12:13
@langchain4j
Copy link
Owner

Hi @KaisNeffati, do you mind if I will do and push some changes?

@KaisNeffati
Copy link
Contributor Author

KaisNeffati commented May 9, 2024 •
edited

Feel free to do it @langchain4j

@langchain4j
Copy link
Owner

@KaisNeffati could you please add me as collaborator to your repo? I can't push to this branch/PR :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langchain4j langchain4j langchain4j requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
P1 Highest priority P2 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaisNeffati @langchain4j