Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: AiMessage text content is not copied when toolCalls are pres… #1069

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hrhrng
Copy link

@hrhrng hrhrng commented May 8, 2024

Issue

#986

Change

When OpenAI returns both content and tool_calls, keep them all instead of just keeping the tool_calls.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green
  • I have added/updated the [documentation

@langchain4j langchain4j added the P3 Medium priority label May 10, 2024
@langchain4j
Copy link
Owner

HI @hrhrng, thank you! I wil ltry to review it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants