New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix 0 retry times #981
Bugfix/fix 0 retry times #981
Conversation
…ugfix/fix_0_retry_times
You're turning "attempts" into "retries" here I'd say. If it's called 'attempts', shouldn't 0 mean an error ( |
so we need do a choice,the utils name is RetryUtils,we can rename the method name or forbidan 0 attempts params, |
I would personally keep it as attempts, so 0 means error, and 1 means try exactly once. But it depends what @langchain4j thinks |
I've changed the number of attempts to a minimum of 1, and 1 for illegal parameters (<=0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaderKai thank you!
Context
#928
Change
Fix wireless retry when retry count is 0
Fix the total number of executions to 1+ retry times
if retry times is less than or equal to 0 is 0
Checklist
Before submitting this PR, please check the following points:
Checklist for adding new embedding store integration