Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jina AI Embedding model integration #997

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

lucifer-Hell
Copy link

Context

This pr is for integration of jina ai embedding model which is mentioned in the issue 973

Change

  1. Since no jina sdk was available for java hence built client for the same .
  2. Added method of embedding generation for both single input and multiple inputs
  3. Default model used jina-embeddings-v2-base-en

Checklist

Before submitting this PR, please check the following points:

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features)
  • I have added my new module in the BOM (only when a new module is added)

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

@langchain4j langchain4j added the P3 Medium priority label Apr 23, 2024
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucifer-Hell thank you a lot! I have left some comments, please check.

langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
langchain4j-jina-ai/pom.xml Outdated Show resolved Hide resolved
@lucifer-Hell
Copy link
Author

thanks for reviewing @langchain4j i will do the changes and re-request for review .

@lucifer-Hell
Copy link
Author

lucifer-Hell commented May 11, 2024

Hi @langchain4j i have fixed naming and version issues. Also changed the Junit version & removed the dependencies which were not required . Please review it once and let me know any further changes have to be done.
PS: I have re-ran all the test cases after the changes .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants