New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jina AI Embedding model integration #997
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucifer-Hell thank you a lot! I have left some comments, please check.
langchain4j-jina-ai/src/test/java/dev/langchain4j/model/jinaAi/JinaAiEmbeddingModelIT.java
Outdated
Show resolved
Hide resolved
langchain4j-jina-ai/src/main/java/dev/langchain4j/model/jinaAi/JinaAiClient.java
Outdated
Show resolved
Hide resolved
langchain4j-jina-ai/src/main/java/dev/langchain4j/model/jinaAi/EmbeddingRequest.java
Outdated
Show resolved
Hide resolved
thanks for reviewing @langchain4j i will do the changes and re-request for review . |
Hi @langchain4j i have fixed naming and version issues. Also changed the Junit version & removed the dependencies which were not required . Please review it once and let me know any further changes have to be done. |
Context
This pr is for integration of jina ai embedding model which is mentioned in the issue 973
Change
Checklist
Before submitting this PR, please check the following points:
Checklist for adding new embedding store integration