-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Postgres Full Text Search tsvector Data Type #2727
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it appears that supporting full text search does not require enabling any optional dependencies, it doesn't need a feature flag. It's perfectly fine for it to be unconditionally compiled, like with the support for ltree
and lquery
.
Hi @abonander, please approve the workflow run, it should now be fixed. |
Hi @abonander, Did you get a chance to look at this again yet? |
I review PRs as I get to them. SQLx is only a small part of my full-time job. Pinging me just fills up my notifications, it won't get your PR reviewed any faster. |
@abonander I understand. Apologies for bothering you with those. |
@anshap1719 can you please rebase and fix conflicts one last time? We're ready to merge this. Note that the type mappings for the macros have moved to their corresponding database drivers: sqlx/sqlx-postgres/src/type_checking.rs Line 10 in 02c68a4
|
Thanks @abonander, I have updated this PR. |
Looks like |
@abonander Right, my bad. Done now. |
@wyhaya Thanks for the review. Will make the changes over the weekend and will also use all the cases you described as test cases. |
@wyhaya Updated everything. Thanks for the code as well. |
Hi @abonander Just FYI, this PR no longer covers |
This reverts commit 279868a.
Oh, guys sorry, but I really need tsvector support, can you check and merge it? @abonander |
Closes #2705
Relates to #729