Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update vcpkg to fix windows CI" #1657

Merged
merged 1 commit into from
May 20, 2024
Merged

Revert "Update vcpkg to fix windows CI" #1657

merged 1 commit into from
May 20, 2024

Conversation

azat
Copy link
Member

@azat azat commented May 18, 2024

windows-vs-job shows this warning:

>(https://github.com/libevent/libevent/actions/runs/8949929874/job/24584751215#step:4:1)
Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet', valid inputs are ['vcpkgDirectory', 'runVcpkgInstall', 'vcpkgGitCommitId', 'vcpkgGitURL', 'doNotUpdateVcpkg', 'doNotCache', 'vcpkgJsonGlob', 'vcpkgJsonIgnores', 'vcpkgConfigurationJsonGlob', 'binaryCachePath', 'runVcpkgFormatString', 'useShell', 'logCollectionRegExps']

Let's simply revert to the last working version, thanks to @hebasto, @Coeur

Fixes: #1648
This reverts commit 3e01178.

@hebasto @azat
ci: Switch lukka/run-vcpkg back to v7
bb1b173 
Newer versions expect a vcpkg manifest.
hebasto
hebasto approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb1b173, all "windows-vs-job" are green and there are no "Unexpected input(s)" warnings.

@azat azat merged commit 525f5d0 into libevent:master May 20, 2024
59 of 70 checks passed
@azat azat deleted the fix-vcpkg branch May 20, 2024 14:17
@azat azat mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet'
2 participants
@azat @hebasto