Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: pass azure custom deployment name to chat model (#2054) #2486

Closed

Conversation

kmahyyg
Copy link

@kmahyyg kmahyyg commented May 14, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

This commit is trying to fix missing model id -> deployment name mapping, so that azure oai is working now without same-name requirement.

This commit is trying to fix issue #2054 by passing correct custom deployment name of AZOAI, parser of model list environment variable is working correctly in previous, just some data is lost in program.

📝 补充信息 | Additional Information

Check issue comment for more details.

Linter passed as required and no error occurred on my side according to WebStorm and interactive test.

This commit is trying to fix missing `model id -> deployment name` mapping, so that azure oai is working now without same-name requirement.
Copy link

vercel bot commented May 14, 2024

@kmahyyg is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @kmahyyg

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (5fc90a9) to head (e1d4f4e).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         334      334           
  Lines       20142    20146    +4     
  Branches     1527     1530    +3     
=======================================
+ Hits        18794    18798    +4     
  Misses       1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmahyyg
Copy link
Author

kmahyyg commented May 23, 2024

closed due to no response and stale.

@kmahyyg kmahyyg closed this May 23, 2024
@arvinxx
Copy link
Contributor

arvinxx commented May 23, 2024

@kmahyyg sorry for the later response.

I'm working on a improvement version here: #2620. And there is some refactor with model list implement.

Please try to check whether this version will work for you after release, If not , feel free to create PR then.

@kmahyyg
Copy link
Author

kmahyyg commented May 23, 2024

Thanks for the excellent work. Currently, 0.161.10 is working on my side. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants