-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store.openKeyCursor fallback to store.openCursor #971
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks so much!
It's a bit late here so I'll get this merged and deployed sometime tomorrow (Saturday) 🙂
is there any chance of this getting merged in? |
also wondering when this might be available - thanks! |
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970 Un correctif est en attente d’intégration : localForage/localForage#971
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970 Un correctif est en attente d’intégration : localForage/localForage#971
Le problème a été introduit dans la 1.7.4 : localForage/localForage#970 Un correctif est en attente d’intégration : localForage/localForage#971
We're also interested in having this in as well. We're having to temporarily patch this for now. |
This problem is made worse coz I found in my use case the old edge javascript engine wasn't handling the exception like other browsers and my it wasn't reaching my automated error reporting. |
Same here, we had to downgrade to |
We have also downgraded to an older version. Will keep watch on this PR. Thanks for working on it! 😄 |
Seems like the Travis CI timed out. @tofumatt, can we maybe re-run it, so we can get this merged? If it's a bug in the PR, I will happily fix it if I can get a little more info on what's going wrong. |
Is there a way we can help move this forward? @banjerluke maybe you can rebase your fork on the current master branch to resolve the conflicts? Hopefully Travis will then successfully run the tests 🤞 |
To support legacy browsers like Edge 18. Fixes localForage#970.
OK, rebased onto master... |
Simple fix to support legacy browsers like Edge 18. Fixes #970.