-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decrease runners after fixed performance degradation #10851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
added
the
semver: patch
Non-breaking changes which can be included in patch releases
label
May 20, 2024
alexrashed
force-pushed
the
revert-fix-timeout-oss
branch
from
May 20, 2024 13:47
4df3683
to
227c043
Compare
alexrashed
changed the title
decrease runners after fixing performance degredation
decrease runners after fixed performance degradation
May 20, 2024
alexrashed
force-pushed
the
revert-fix-timeout-oss
branch
from
May 20, 2024 16:01
227c043
to
aadea8c
Compare
viren-nadkarni
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
silv-io
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #10742,
moto-ext
was upgraded to5.0.6.post2
.Unfortunately, this release caused a performance degradation, which was addressed in getmoto/moto#7700.
This fix landed in
localstack
with #10843.While this fix was in progress / not yet in affect, we updated our runner config to avoid any timeouts with #10833 and #10837.
This PR reverts this increased amount of runners now that the performance degradation has been fixed.
Changes
TODO
58m 4s
57m 53s
54m 30s
master
(with more runners)57m 56s
47m 36s
45m 58s
moto-ext
bump (with same amount of runnners as this PR)47m 22s
master
(with more runners)39m 44s