Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease runners after fixed performance degradation #10851

Merged
merged 6 commits into from
May 22, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented May 20, 2024

Motivation

With #10742, moto-ext was upgraded to 5.0.6.post2.
Unfortunately, this release caused a performance degradation, which was addressed in getmoto/moto#7700.
This fix landed in localstack with #10843.
While this fix was in progress / not yet in affect, we updated our runner config to avoid any timeouts with #10833 and #10837.
This PR reverts this increased amount of runners now that the performance degradation has been fixed.

Changes

  • Revert parallelism back to 4.
  • Update the test durations once more.

TODO

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label May 20, 2024
@alexrashed alexrashed added this to the 3.5 milestone May 20, 2024
@alexrashed alexrashed self-assigned this May 20, 2024
@alexrashed alexrashed changed the title decrease runners after fixing performance degredation decrease runners after fixed performance degradation May 20, 2024
Copy link

github-actions bot commented May 20, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 41m 35s ⏱️ + 1m 5s
2 980 tests ±0  2 675 ✅ ±0  305 💤 ±0  0 ❌ ±0 
2 982 runs  ±0  2 675 ✅ ±0  307 💤 ±0  0 ❌ ±0 

Results for commit 7c94311. ± Comparison against base commit a462e47.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed marked this pull request as ready for review May 22, 2024 08:23
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexrashed alexrashed merged commit 9caf638 into master May 22, 2024
32 checks passed
@alexrashed alexrashed deleted the revert-fix-timeout-oss branch May 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants