-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ONNX Model Quantization #3837
Open
ethanreidel
wants to merge
18
commits into
ludwig-ai:master
Choose a base branch
from
ethanreidel:onnxchanges
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d9f03d.
ethanreidel
requested review from
w4nderlust,
tgaddair,
justinxzhao,
arnavgarg1,
geoffreyangus,
jeffkinnison,
Infernaught and
alexsherstinsky
as code owners
December 16, 2023 00:32
Noting: need to add onnxruntime to requirements |
Unit Test Results 6 files ± 0 6 suites ±0 13s ⏱️ - 13m 54s For more details on these errors, see this check. Results for commit fcc0abc. ± Comparison against base commit 7e8fc14. This pull request removes 12 and adds 6 tests. Note that renamed tests count towards both.
This pull request removes 3 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Pull Requests
Please provide the following:
Expands on @saad-palapa and @skanjila implementation of the ONNX exporter. Adds ability to quantize ONNX model to uint8 weights. Be aware that this PR does add 3 new .onnx model files strictly for testing based on squeezenet architecture.
Addition to this issue: Export computer-vision model to ONNX #3659
tests->ludwig->model_export->test_onnx_exporter.py (tests->ludwig->model_export->sampleonnxmodel contains test onnx models)
Other issues:
Currently test_quantize_onnx_model is passing but with a lot of warnings.
Quantization parameters for tensor:"x" not specified
Quantization parameters for tensor:"/features/features.2/MaxPool_output_0" not specified
Continued...
Thanks for looking at this PR!