Add LibreOffice icons

[Finii]

These files originate from

• Add libreoffice files icons ryanoasis/nerd-fonts#1527

by @Gaspartcho

[hasecilu]

Actually I wanted to also include LibreOffice specific icons here but since they a little complex I decided to not do it and use the generic office icons for this PR: eza-community/eza#565

@Gaspartcho, do you planned other use case apart from terminal? At least we can try to see how would be use them for LibreOffice files, they are very cool indeed.

[Gaspartcho]

The reason I initially wanted to put these icons was that the text editor I use used the icons from NerdFonts in order to show file icons in the treeview

[hasecilu]

I made a test and this is how it would look like with some different sizes with eza

vs

Here is the font if you want to test for your use case:

Icon	Position
LibreOffice	0xf373
LibreOffice Base	0xf374
LibreOffice Calc	0xf375
LibreOffice Draw	0xf376
LibreOffice Impress	0xf377
LibreOffice Math	0xf378

SymbolsNerdFont-Regular.ttf.zip

[Finii]

My opinion...

The small details that make the icons different are a bit ... small. And hard to discern.
Of course we could enlarge that details.

Otoh I really hate these Microsoft centric icons with p and x 😒

Edit: Also that odf and odg have no file-border while the odp odt ods have is strange.

[hasecilu]

Of course we could enlarge that details.

Could be useful to make another test

Otoh I really hate these Microsoft centric icons with p and x 😒

Me too.

Edit: Also that odf and odg have no file-border while the odp odt ods have is strange.

The odg is the generic vector icon and odf just sqrt(2), since those extensions are specific to OpenDocument format the LibreOffice icons can be a good fit.

[Finii]

Hmm, seeing them irl here, they do not look as bad as expected.

[hasecilu]

I made a test enlarging the writer logo, I think that size is good, details are more easily recognizable. See f.odt2 file icon.

I took file from /usr/share/icons/hicolor/scalable I have LibreOffice 24.2.2-2

[Finii]

Nice idea 👍

But you change the content itself instead of just scaling up. I'm not sure that it is then still 'the same logo'.
Here a quick n dirty Gimp manipulation with just scaling up the text-and-image thing without further modification.

[hasecilu]

The old icons already have 2 years from last update on help module: https://github.com/LibreOffice/help/tree/master/source/media/navigation which is the source from simple-icons

The new ones are here, also from 2 years ago but have these modern, rounded design in core package: https://github.com/LibreOffice/core/tree/3ca12a07335e1e9ae6b64491faaab6a46e9c4db5/sysui/desktop/icons/hicolor/scalable/apps

Branding page: https://wiki.documentfoundation.org/Design/Branding

See difference:

Edit: Testing branch -> https://github.com/hasecilu/font-logos/tree/test/libreoffice

Previous icons are not rounded but their elements are slightly bigger.

[hasecilu]

This is a comparative of different small sizes with the both group of icons.

The first pack of logos are the older ones at original scale, the second pack contains the newer logos with an increase in the central glyphs to make it more differentiable at small scales (as would be expected on most terminal emulators).

In the first pack the glyphs are well centered, in the second pack seems to be a more like in the bottom because of the top corner cut.

[Finii]

Excellent.
I went through their icons and you are right they changed them a bit.

I believe they (your modified icons) look very good.

Just some comment (of course 😉 )

• The blank file black block has more room in the bottom than in the top, maybe move down 'a pixel'
  Even with small sizes I noticed that immediately.
• And I like the distance between symbol and border for draw (square, triangle, circle) better than the other icons where the symbol feels more down. Yes the other symbols are taller, but maybe we can nudge them a bit up. I guess they will not yet collide with the folded corner thing. Esp 'math' and 'database' (?) seem very low and still the is space in the top.

Nice work! 👍

Edit: Add this image from 'afar':

[Finii]

I guess you should just cherry pick your commits into this branch. After tweaking if you like. 🐱
Then we have later on this discussion linked with the commits.

[hasecilu]

I modified the main (effectively with one extra pixel in height), base and math icons, now look better. The impress and writer icons I think are ok-ish, maybe to move up a little the calc icon, what do you think?

[Finii]

Just git organizational:
Replace merging in master into this branch by rebasing on master, making the commit line much more easy.
Force push.

Just to clean up the commit log, no change except that now we also have the updated FreeCad logo in this and and continue with a simple fastforward or the likes.

Edit:
To continue with your local repo you need something like git fetch && git reset --hard origin/feature/add-libreoffice or so, to pull in the force push. If you need this hint at all.

Old:

New:

[Finii]

This all looks excellent!

But as you ask, yes, Calc could go up a bit.

[Finii]

Unrelated:
Hmm, just noticed this while building...

[hasecilu]

To continue with your local repo you need something like git fetch && git reset --hard origin/feature/add-libreoffice or so, to pull in the force push. If you need this hint at all.

Thanks, I tried rebasing and somehow messed history.

I tweaked cal, draw, impress & math to make them to be at about 3.1px from the bottom. No central glyph overpass the start of the corner diagonal.

---

About the build message and don't get it using aur/wkhtmltopdf-static from AUR

$ wkhtmltoimage --version
wkhtmltoimage 0.12.6.1 (with patched qt)

[Finii]

I think this looks excellent!!

Marking this as ready.

---

I tried rebasing and somehow messed history.

To be honest I did not rebase either, but did

$ git reset --hard origin/master
$ git cherry-pick 580fc1f6573307aa643aaccfb092c226f6691b2a 
$ tig
$ git cherry-pick 2515332f1c82f9ecde38e59e430ecbd4701d4fe2
$ git status
$ vi icons.tsv
$ git add icons.tsv
$ git cherry-pick --continue
$ tig
$ git diff origin/feature/add-libreoffice
$ tig
$ git push --force-with-lease

You see I love tig ;-)

[Finii]

About the build message and don't get it using aur/wkhtmltopdf-static from AUR

$ wkhtmltoimage --version
wkhtmltoimage 0.12.6.1 (with patched qt)

Hmm, our CI also has 'my' problem:

I will check that, if I do not forget ;-)

There seem to be also some old actions that need update... Maybe. Or did we do that already? I thought all repos I do the CI for have been updated meanwhile ;-)

[Finii]

Smuggling unrelated fix in ;-D

[hasecilu]

You see I love tig ;-)

Didn't know about that tool, personally I use lazygit TUI, very handy to reword, ammend, cherry-pick, etc.

So, we just need to squash the fixup! commit...
This is the log of lazygit for "Apply fixup commits..." action

[Finii]

Ah :-)

I do all git commands by hand, maybe I am too old. git rebase -i and then just set the commits to s for squash.
tig I use for git log and git show and occasionally for git blame. But then often the original git commands are more powerful (esp in case of log).

Coworkers get the zine "Oh shit, git" from me :-D and in the coffee kitchen hangs her git command list

https://wizardzines.com/zines/oh-shit-git/
Can't find the command list right now...

You merge this I presume? I can not formally approve because it is my own PR.

[hasecilu]

All SVGs seems to be fine, and render fine on viewers and terminal.
I removed the "WIP: " from the commit.

[hasecilu]

Ah :-)

I do all git commands by hand, maybe I am too old. git rebase -i and then just set the commits to s for squash. tig I use for git log and git show and occasionally for git blame. But then often the original git commands are more powerful (esp in case of log).

Coworkers get the zine "Oh shit, git" from me :-D and in the coffee kitchen hangs her git command list

https://wizardzines.com/zines/oh-shit-git/ Can't find the command list right now...

You merge this I presume? I can not formally approve because it is my own PR.

I tend to use a bunch of aliases but when commands become long & scary I prefer to use TUI

[Finii]

Here's the thing I hung in our coffee kitchen ;-D

git-cheat-sheet.pdf

[Finii]

Just changed the commit message slightly.

Working / collaborating on the PR was nice 💚

git fetch
git checkout feature/add-libreoffice
git reset --hard origin/feature/add-libreoffice
tig
git rebase -i HEAD~3
git push --force-with-lease

In the interactive rebase, tag the main commit with e (edit) and edit the commit message.

Which now also references the PR, so we do not need a merge commit anymore (which I usually create only to have some backlink to the PR discussions. Which already also bite me several times, as the repo moved from one platform to another (stash -> gitlab -> github) and thus the discussed information is lost forever - should probably been in the commit message 😒 ).