Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request from myeong-ji univercity computer engineering opensource-software class project #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ta-mj
Copy link

@ta-mj ta-mj commented Dec 6, 2022

Hi lxgr-linux,
I am taewoo Park from Myeong-ji Univercity Computer Engineering.
My project group in opensource-software class had to analyze and improve one opensource software project.
So We chose your pokete project and proceed project activity.
And we find some improvement point.

The modifications about them are as follows.

  1. char icon : When we start the game, player and npc 's char are both 'a' . But now, after player enter the name,
    char change to name's first letter.
  2. interaction with npc : When we go near the NPC, the conversation with npc starts automatically.
    So, we modified the code to start the conversation when you press the 'Accept' key when you go near the NPC.
  3. skip the animation
    Battle and some attack animations are too long to make users bore the user. So just like conversation with NPC,
    we modified the code to skip the animation when you press the 'Accept' key.
  4. adjust some probabillity and value
    And more, we modified the probablility of pokemon appearance, remove the effect, attack when poke is in effect.
    And we increased poke's hp when they level up, and we improved all poke's damage.

We want to hear your feedback and want to be the contributor of your project.
Thank you.

@ta-mj
Copy link
Author

ta-mj commented Dec 6, 2022

In addtion, we added some pokemon and attacks and a achievement.

TheKingOfLight pushed a commit to TheKingOfLight/pokete that referenced this pull request Jan 31, 2024
Merged most of ta-mj requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant