Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules #38726

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mattkrupnik
Copy link

@mattkrupnik mattkrupnik commented May 15, 2024

Description (*)

In instance where we have custom shipping methods without shipping rates validation rules, the loader blocks the shipping methods after the postcode is changed in the shipping address during checkout and does not disappear.

File: vendor/magento/module-checkout/view/frontend/web/js/model/shipping-rates-validator.js

image

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules #38742: The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules

Copy link

m2-assistant bot commented May 15, 2024

Hi @mattkrupnik. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mattkrupnik
Copy link
Author

@magento run all tests

@mattkrupnik mattkrupnik reopened this May 15, 2024
@mattkrupnik
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard May 21, 2024
@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label May 21, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] The loader blocks the shipping methods after the postcode is changed, shipping rates validation rules
3 participants