Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1262] refactor: custom hook for common dropdown logic #4420

Merged
merged 3 commits into from
May 22, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented May 9, 2024

Improvements:

  1. Clear dropdown search query on closing.

Refactor:

  1. Created a custom useDropdown hook to handle common dropdown functions.

Media:

Before After
Screen.Recording.2024-05-16.at.17.46.28.mov
Screen.Recording.2024-05-16.at.17.48.14.mov

Plane issue: WEB-1262

@aaryan610 aaryan610 marked this pull request as draft May 9, 2024 20:38
@aaryan610 aaryan610 changed the title refactor: custom hook for common dropdown logic [WEB-1262] refactor: custom hook for common dropdown logic May 16, 2024
@aaryan610 aaryan610 added this to the v0.20-dev milestone May 16, 2024
@aaryan610 aaryan610 marked this pull request as ready for review May 16, 2024 12:20
@pushya22 pushya22 marked this pull request as draft May 17, 2024 09:08
@pushya22 pushya22 marked this pull request as ready for review May 21, 2024 10:43
@SatishGandham SatishGandham merged commit 639d24b into preview May 22, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the refactor/dropdowns branch May 22, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants