Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/form] use-form: add submitting and submitError + methods #4020

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philipodev
Copy link

as per #4011

use-form

  • Added submitting, submitError fields
  • Added setSubmitting, setSubmitError and resetSubmitError methods

Copy link

@treemmett treemmett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Hopefully this gets implemented soon.

Comment on lines +57 to +58
const [submitting, _setSubmitting] = useState(false);
const [submitError, _setSubmitError] = useState<SubmitError>(null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should get reset in the reset callback

@rtivital rtivital changed the base branch from dev to master September 24, 2023 09:42
@rtivital rtivital force-pushed the master branch 11 times, most recently from 9ea2fcd to eebd557 Compare December 8, 2023 13:46
@rtivital rtivital added the Reviewed PR Reviewed PR, most likely will not be merged. PR may be kept open for context or as a reminder. label Jan 27, 2024
@laugri
Copy link

laugri commented Mar 25, 2024

Hello, will this be implemented at some point ?

@ldalves
Copy link

ldalves commented Apr 29, 2024

We are currently migrating a huge project from React Hook Form to mantine/form and we are very interested in this feature. Any estimates when this might be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR Reviewed PR, most likely will not be merged. PR may be kept open for context or as a reminder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants