-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(field): make required asterisk optional #5616
feat(field): make required asterisk optional #5616
Conversation
4952f9d
to
be5bb43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Do you mind adding the same property to the select component?
Not at all. I added the property to the select component, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
PiperOrigin-RevId: 636585863
I think more commits got pushed to the PR before copybara finished the import, so it didn't merge propertly. Sorry about that! This got added in c5e87b2 though, so we can close the PR now :) |
Fixes #5256
Makes the required asterisks optional on text fields by adding an
no-asterisk
prop.