-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small a11y fixes #20810
base: 5.x-dev
Are you sure you want to change the base?
small a11y fixes #20810
Conversation
Hi @luce-carevic, |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
@luce-carevic Thanks for providing this PR. The changes around |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
The tabindex are not useful here. The tab order will follow the order in the DOM. I don't know how to do what you asked. Maybe I should make an issue instead of a PR? |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
Description:
Adding aria-hidden="true" on the tag will hide them.
You should not rely on value superior to 1 because the risk is high to mess with the keyboard navigation.
cf. https://www.tpgi.com/using-the-tabindex-attribute/
Review