Check privilege sql has been successful on install script #22208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The installation script expects an exception to be thrown when testing installation queries.
However the MYSQLI adapter does not behave like this so it is possible to install with a DB user who has not been granted the "CREATE TEMPORARY TABLES" privilege.
This PR add a check on the return to confirm if the query has actually been successful.
fixes #22187
checkSqlReturn.webm
Review